ENH: Relax restrictions on forcing amd64 images#17
Open
mberz wants to merge 3 commits into
Open
Conversation
arm64 images can be built when installing python3-gmsh via the apt package manager instead of pypi
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the de_method container build to better support arm64 (e.g., macOS Apple Silicon building linux/arm images) by sourcing the Gmsh Python bindings from the OS package manager instead of relying on PyPI wheels, and relaxes CI’s forced amd64 build for this method.
Changes:
- Install
python3-gmsh(andlibgmsh-dev) viaapt-getin thede_methodDocker image. - Expose the Debian-installed
gmshPython module to the/usr/localPython environment via symlinks into site-packages. - Remove the explicit
--platform=linux/amd64flag from theacousticDEDocker build workflow step.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
de_method/Dockerfile |
Installs system Gmsh Python bindings and makes them importable from the image’s Python environment to support arm64 builds. |
.github/workflows/acousticDE.yml |
Stops forcing amd64 in the Docker build step, enabling native-arch builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Enables linux/arm64 support for gmsh
The dependency management for gmsh should be replaced with a better solution
mberz
changed the title
Comment on lines
28
to
32
| dependencies = [ | ||
| "numpy>=1.23.0", | ||
| "gmsh", | ||
| "pyroomacoustics>=0.8.0", | ||
| "requests", | ||
| "pyfar>=0.8.0", |
Comment on lines
+1
to
+2
| # Use Python 3.11 slim image for smaller size | ||
| FROM python:3.11-slim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes