Skip to content

refactor: MusicBrainzCredits is MusicBrainzLookups - #218

Merged
chodeus merged 1 commit into
mainfrom
refactor/musicbrainz-lookups
Oct 22, 2026
Merged

chodeus merged 1 commit into
mainfrom
refactor/musicbrainz-lookups

Conversation

@chodeus

@chodeus chodeus commented Oct 22, 2026

Copy link
Copy Markdown
Owner

What

MusicBrainzCredits has read recordings as well as artist credits since #216, so it is renamed MusicBrainzLookups, with its interface, file and tests. The tagger's field and the sibling-album specification's parameter follow. No behaviour changes; the plugin's services are registered by convention, so the interface and class keep their pairing.

Tests

  • Full suite passes; MusicBrainzLookupsTests is the renamed MusicBrainzCreditsTests, unchanged.

It reads recordings as well as artist credits since #216. The interface,
class, file and tests are renamed; no behaviour changes.
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 90 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: chodeus/sleezer/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: 1a2377fa-d2d9-46f0-a0ea-ab81dadda327
📥 Commits

Reviewing files that changed from the base of the PR and between e1df531 and 8335496.

📒 Files selected for processing: 6
  • src/Sleezer/Core/DecisionEngine/SiblingAlbumSpecification.cs
  • src/Sleezer/Core/PostProcessing/PreImportTagger.cs
  • src/Sleezer/Core/Utilities/MusicBrainzLookups.cs
  • tests/Sleezer.Tests/FakeHttpClient.cs
  • tests/Sleezer.Tests/MusicBrainzLookupsTests.cs
  • tests/Sleezer.Tests/Sleezer.Tests.csproj
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@chodeus
chodeus marked this pull request as ready for review October 22, 2026 03:37
@chodeus
chodeus merged commit 813ed29 into main Oct 22, 2026
5 checks passed
@chodeus
chodeus deleted the refactor/musicbrainz-lookups branch October 22, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant