Repository navigation
refactor: MusicBrainzCredits is MusicBrainzLookups - #218
Merged
Merged
Conversation
It reads recordings as well as artist credits since #216. The interface, class, file and tests are renamed; no behaviour changes.
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 47 minutes. View limit details
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MusicBrainzCreditshas read recordings as well as artist credits since #216, so it is renamedMusicBrainzLookups, with its interface, file and tests. The tagger's field and the sibling-album specification's parameter follow. No behaviour changes; the plugin's services are registered by convention, so the interface and class keep their pairing.Tests
MusicBrainzLookupsTestsis the renamedMusicBrainzCreditsTests, unchanged.