Fix actionable build warnings - #181
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
System.Text.RegularExpressionstest dependency and central versionGetSourcePositionStringa non-null extension receiver while retaining nullable source-position equalityWhy
The .NET 10 build identified a framework-provided package that can be pruned, resource designer sources that were supplied both by the resource generator and explicit compile items, and a nullable receiver shared by extension methods with different nullability contracts.
This reduces a forced build from 10 warnings to the five generated
SymbolBuilderobsolescence warnings that are intentionally deferred.Impact
Build output is quieter without changing runtime behavior or generated parser code.
Validation
dotnet build --nologo --no-restore --no-incremental --consoleLoggerParameters:NoSummary(passes; five intentionally deferred generatedCS0618warnings)dotnet test --nologo --no-build --no-restore --consoleLoggerParameters:NoSummary(1,459 total; 1,456 passed; 3 skipped)dotnet csharpier check .(512 files checked)