Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Three loose ends from the audit. On QuickAdd before 2.31 the
[[and#pickers showed the Obsidian CLI's raw "Command not found" text. A number field that failed validation looked empty while its error said "Between 1 and 5". Quick Capture had not been run live since the capture refactor in #6.What changed
suggest.tsmaps the CLI's "Command "quickadd:suggest" not found" text to "Link and tag completion needs QuickAdd 2.31 or later." Other errors pass through. The pickers' empty view shows it.Scope
No change to Quick Capture. It was run live and works as is.
Verification
Vault not found.passes through. It fails with the mapping removed.9typed at +0.76 s and at +4.1 s showed in the field. After submit the field read empty next to "Between 1 and 5". So the keystroke was not dropped; the error re-render cleared it. After the fix the field keeps9beside the error. Correcting it to3and submitting wrote- rating: 3toOutput/Inbox.md.- text: polish quick capture 2114toOutput/Inbox.md. The toast read "Added to Output/Inbox.md".pnpm lint,pnpm test(76 passed),tsc --noEmit,pnpm build, andpnpm e2e:protocol(13 passed) are green.