fix: stage skills before the change check in sync workflow#5
Merged
Conversation
git diff (no --cached) ignores untracked files, so a brand-new file — a new skill directory, or a new references/*.md — read as no change and the job exited before git add. Only edits and deletions to already-tracked files ever propagated. Stage first, then gate on the staged diff so new files are seen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The
Commit and push if changedstep gated ongit diff --quiet skills/.git diff(no--cached) only inspects tracked files, so a brand-new untracked file is invisible to it. The job reported "No skill changes" and exited beforegit add.This is deterministic, not a caching/timing issue — re-running never helps. Practical effect: no skill that introduces a new file has ever synced. Only edits and deletions to already-tracked files propagated. (The recently-added playwright skill landed via PR, not the daily job — which is why this went unnoticed.)
Fix
Stage first, then gate on the staged diff (
git diff --cached --quiet). The step already rangit add skills/immediately before committing, so this just moves that line above the guard — the smallest correct change.Test plan
workflow_dispatch) commits new files; CI logs confirm the staged-diff gate sees them