Open the README with an example that runs, and needs no network - #30
Closed
ShawnChen-Sirius wants to merge 2 commits into
Closed
ShawnChen-Sirius wants to merge 2 commits into
ShawnChen-Sirius wants to merge 2 commits into
Conversation
The first snippet had no imports, no main, no run line, and queried a URL over the network three lines under a sentence saying there is none. It also never said that a native package has to match the platform, which is the one thing a first run gets wrong. Now: a complete file that prints 1, the classpath it needs, the four platform artifact ids, and a link to QuickStart.java for the longer version. The url() example stays, one line further down, where it can say what it is -- the engine is in-process, the data need not be. Extracted from the README and run before committing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Review of #30, all three right. The jars in a bundle carry versions, so bare chdb-jdbc.jar names nothing; `java -cp` without `.` cannot find Hello.class even when it exists; and the class was never compiled. The QuickStart line had the same shape of problem -- exec:java in a fresh checkout has no native package to load -- so it now carries the full sequence from QuickStart's own javadoc. Run verbatim against an installed preview before committing: javac, then java with the versioned jar names, prints 1. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
All three fixed, and each was real.
Verified by running the block verbatim against an installed preview: prints |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review of #29, applied before the preview is tagged —
package-preview.shputs README.md inevery bundle, so this is the copy users get.
The old first snippet had no imports, no
mainand no run command, and it queriedurl('https://example.com/logs.jsonl')three lines below "no server, no network". It alsonever said a native package has to match the platform you run on.
Now: a complete file that prints
1, thejava -cpline, the four platform artifact ids, anda link to
QuickStart.javawith the command from its own javadoc. The
url()example survives one paragraph down, whereit can say what it is — the engine runs in-process, the data does not have to.
Extracted from the README verbatim, compiled and run against the installed preview: prints
1.🤖 Generated with Claude Code
Note
Replace README intro with a runnable no-network
HelloJDBC exampleHelloclass that executesSELECT 1and prints the integer result, with command-line compile and run instructionsurlquery example and links the longerQuickStartwith source-checkout build and run commandsMacroscope summarized 4a5744d.