feat: enable TLS certificate compression#8447
Merged
Merged
Conversation
Enabling brotli does not add new dependencies, we have it already. Documentation at <https://docs.rs/rustls/0.23.42/rustls/compress/> recommends enabling at least brotli. zlib feature is not enabled as it pulls in duplicate zlib-rs 0.6.6 zlib was even never supported in Chromium (while brotli is). It might still be interesting to enable it in the future because it seems to be the only option supported by OpenSSL and there may be servers that support zlib but not brotli. RFC 8879 specifies zstd as well, but there is no feature to enable it yet. This also brings back explicit TLS 1.2 feature that was reverted. We don't want TLS 1.2 support to be accidentally dropped if no dependencies explicitly require it anymore.
link2xt
force-pushed
the
link2xt/enable-cert-compression
branch
from
July 21, 2026 19:36
0452a86 to
2523c01
Compare
hpk42
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling brotli does not add new dependencies,
we have it already.
Documentation at https://docs.rs/rustls/0.23.42/rustls/compress/ recommends enabling at least brotli.
zlib feature is not enabled as it pulls in duplicate zlib-rs 0.6.6 zlib was even never supported in Chromium (while brotli is). It might still be interesting to enable it in the future because it seems to be the only option supported by OpenSSL and there may be servers that support zlib but not brotli.
RFC 8879 specifies zstd as well, but there is no feature to enable it yet.
This also brings back explicit TLS 1.2 feature that was reverted. We don't want TLS 1.2 support to be accidentally dropped if no dependencies explicitly require it anymore.