Font issue fixed, custom style for slack counter#147
Open
princesust wants to merge 6 commits into
Open
Conversation
Font issue fixed, custom style for slack counter
Owner
|
Hey @princesust, Thanks for the PR, I can take a look at it in a couple of hours after I'm done with my work day. Thank you for taking the time to open the PR. |
type checking issue fixed
Author
|
Hi @charkour, |
dynamic font related code removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we don't need to put slack fonts in public/fonts directory
We can pass slack counter style properties like below
This styles will be merged with default
addStyle