refactor(adapter): simplify converter metadata while preserving payload contracts - #170
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converter Definitions repeat carrier labels and output capacity declarations already owned by slots and ValueTypes. This change derives those values and removes redundant Definition fields and helper parameters, while keeping schema_id mandatory and comparing it for both input and output contracts across bindings of the same business.
Operator ABI, Pipeline JSON, and deployment .conf remain unchanged. Catalog, constructor callers, and current guides are updated together. A regression test uses the real plain-text and JSON translation converters to verify that identical carriers with different payload semantics cannot be combined under one business.
Validation: the reviewed worktree passed the canonical local gate with 103/103 CTest tests. The delivery script reran the canonical gate before commit and push; it also passed with 103/103 CTest tests. The original misuse reproduction now fails contract validation, registry audit, and deployment preflight. Native Catalog, validate-io, plan, and resolve-conf checks passed. Browser workflows were skipped because STUDIO_PLAYWRIGHT_MODULE is unset; real-model, sanitizer, and target-hardware acceptance were not run.