[codex] Fix main CI failures#39
Draft
jessmartin wants to merge 1 commit into
Draft
Conversation
Add the Linux ALSA development package needed by the workspace build, refresh the JS SDK lockfile, apply cargo fmt, and fix warnings surfaced by the CI clippy/check configuration. Validated with: cargo fmt --all -- --check; git diff --check; RUSTFLAGS='-D warnings' cargo clippy --workspace --exclude freeq-av-client --exclude freeq-eliza --exclude freeq-av --exclude freeq-av-image -- -D warnings; RUSTFLAGS='-D warnings' cargo check/test with the same excludes; npm ci/build/audit for freeq-app and freeq-sdk-js; cargo audit.
9a26a82 to
b1e363e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libasound2-devin the Rust check/clippy jobs because the workspace still buildsclaude-mcp, which reachescpal/alsa-systhroughfreeq-avon Linuxfreeq-sdk-js/package-lock.jsonsonpm cican resolve the missing@emnapi/runtimepeer entrycargo fmt --alland fix warnings/clippy findings surfaced by the current CI configurationValidation
cargo fmt --all -- --checkgit diff --checkRUSTFLAGS=''-D warnings'' cargo clippy --workspace --exclude freeq-av-client --exclude freeq-eliza --exclude freeq-av --exclude freeq-av-image -- -D warningsRUSTFLAGS=''-D warnings'' cargo check --workspace --exclude freeq-av-client --exclude freeq-eliza --exclude freeq-av --exclude freeq-av-imageRUSTFLAGS=''-D warnings'' cargo test --workspace --exclude freeq-av-client --exclude freeq-eliza --exclude freeq-av --exclude freeq-av-imagenpm ci && npx tsc --noEmit && npm run buildinfreeq-appnpm ciinfreeq-sdk-jsnpm audit --omit=dev --audit-level=highinfreeq-appandfreeq-sdk-jscargo audit