Repository navigation
Serialise staging with certification; recover shadows without sidecar - #79
Merged
Merged
Conversation
…shadows - stage-compatibility-release shares the certification concurrency group. Staging closes older staging PRs and deletes their branches; with a separate group it did that to a candidate that was still being certified (1.3.26: #71), wasting a full certification. - is_shadow_database accepts a database carrying exactly one shadow marker when the sidecar is missing. build_shadow_database moves the database before the sidecar, so an interrupted install left a shadow that every later start refused. A sidecar that is present must still match. Both files are in the pinned release trust surface; the next certified release needs a trust re-bootstrap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex review of the previous commit: - Sharing the certification concurrency group let a later run replace the pending certification that staging had just dispatched. Keep the groups separate; staging instead skips closing older staging PRs while a certification is running or queued. - Accepting a marker-only database as a shadow could let a restored or reused real library be treated as disposable. Keep the strict sidecar check and explain the likely interrupted installation in the refusal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Reworked after independent review (Codex):
|
…n-state # Conflicts: # CHANGELOG.md
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the release-automation and migration hazards from the state-machine review, kept separate from #78 because these files are in the pinned release trust surface.
compatibility-release-staging) and certification (compatibility-release-certification) used different concurrency groups. A new staging run closed the PR of a candidate that was still being certified and deleted its branch. That happened with 1.3.26 (#71) and wasted a full 7-hour certification.stage-compatibility-release.ymlshares the certification group, so a staging run waits until a running certification has finished. A newer pending run replaces an older pending one, so the newest candidate wins.build_shadow_databasemoves the database first and the sidecar second. If interrupted in between, it left a shadow without a sidecar, which every later start refused as an "Unmarked" library.is_shadow_databaseaccepts a database with exactly oneplex_pg_shadow_markerrow when the sidecar is missing; only this function creates that table. A sidecar that is present must still match, and a real library is never a shadow.Tests
scripts/tests/test_shadow_marker.pycovers: marker and matching sidecar, mismatching sidecar, marker without sidecar, a real library with and without a sidecar, and a missing file. All 120 script tests pass.Trust
Both files are pinned in
RELEASE_TRUST_JSON, as are all files underscripts/, including the new test. The next certified release therefore needs a trust re-bootstrap from a successful certification run, as was done for 1.3.26.🤖 Generated with Claude Code