🐛 Allow callFollowingErrorInterceptor when rejecting in ErrorInterceptorHandler#2543
Open
AlexV525 wants to merge 3 commits into
Open
🐛 Allow callFollowingErrorInterceptor when rejecting in ErrorInterceptorHandler#2543AlexV525 wants to merge 3 commits into
callFollowingErrorInterceptor when rejecting in ErrorInterceptorHandler#2543AlexV525 wants to merge 3 commits into
Conversation
RequestInterceptorHandler and ResponseInterceptorHandler both support the callFollowingErrorInterceptor flag in their reject() methods, but ErrorInterceptorHandler.reject() was missing it, always emitting InterceptorResultType.reject and causing subsequent error interceptors to be skipped unconditionally. The errorInterceptorWrapper in dio_mixin.dart already handles rejectCallFollowing correctly, so only the handler method needed fixing. Fixes #2462 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a regression test to ensure calling ErrorInterceptorHandler.reject(error, true) inside QueuedInterceptorsWrapper continues to following error interceptors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2462
RequestInterceptorHandlerandResponseInterceptorHandlerboth expose acallFollowingErrorInterceptorflag in theirreject()methods, butErrorInterceptorHandler.reject()was missing it — it always emitsInterceptorResultType.reject, unconditionally skipping any subsequent error interceptors.The
errorInterceptorWrapperindio_mixin.dartalready handlesrejectCallFollowingcorrectly, so only the handler method needed updating.