Optimize pagination query#250
Merged
Merged
Conversation
The search API response includes a set of "break points" which can be used as pagination offsets in subsequent queries. These break points are always computed if the search response would contain more than one page of results. Break points are computed via a second OpenSearch query. Currently, that second query is essentially a duplicate of the original search, which means that includes all of its bells and whistles: computing aggregations, highlighting results, etc. We don't actually need any of that stuff, and it's very expensive to compute. The second search can and should only be used to return break points. This change modifies that second search to remove those extraneous features from the OpenSearch query.
chosak
force-pushed
the
optimize/pagination
branch
from
July 21, 2026 19:33
15f55d8 to
f648ce3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search API response includes a set of "break points" which can be used as pagination offsets in subsequent queries. These break points are always computed if the search response would contain more than one page of results. Break points are computed via a second OpenSearch query.
Currently, that second query is essentially a duplicate of the original search, which means that includes all of its bells and whistles: computing aggregations, highlighting results, etc. We don't actually need any of that stuff, and it's very expensive to compute. The second search can and should only be used to return break points.
This change modifies that second search to remove those extraneous features from the OpenSearch query.