Honor the no_aggs parameter when searching#248
Merged
Merged
Conversation
The search API includes a "no_aggs" parameter which is supposed to determine whether aggregations are included in the output, but it is currently ignored. The API accepts that parameter and validates it, but ignores it. Aggregations are always computed, no matter what. Computing aggregations is an expensive part of the search, and requires grouping every complaint by company, issue, and sub-issue. This change properly checks no_aggs before adding aggregations to the search query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search API includes a "no_aggs" parameter which is supposed to determine whether aggregations are included in the output, but it is currently ignored.
The API accepts that parameter and validates it, but ignores it. Aggregations are always computed, no matter what. Computing aggregations is an expensive part of the search, and requires grouping every complaint by company, issue, and sub-issue.
This change properly checks no_aggs before adding aggregations to the search query.