Various test / policy file cleanups guided by cfengine lint#6115
Open
olehermanse wants to merge 6 commits intocfengine:masterfrom
Open
Various test / policy file cleanups guided by cfengine lint#6115olehermanse wants to merge 6 commits intocfengine:masterfrom
olehermanse wants to merge 6 commits intocfengine:masterfrom
Conversation
cfengine lint generally considers empty files to be a problem, because they could be the result of a failed transfer, failed write, or similar. Thus, adding a comment here to avoid having an empty .cf file. Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Didn't change all of them - left the ones which seem like the test is for testing ifvarclass specifically. Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
The test using this file was removed in: ef10f3b 13 years ago. Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
olehermanse
added
the
cherry-pick?
Member
Author
|
@cf-bottom jenkins please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13732/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13732/ |
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
nickanderson
approved these changes
May 6, 2026
Member
Author
|
Waiting for Jenkins |
Contributor
|
@cf-bottom jenkins |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13742/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13742/ |
craigcomstock
approved these changes
May 6, 2026
Contributor
craigcomstock
left a comment
craigcomstock
left a comment
There was a problem hiding this comment.
looks fine to me. I am investigating valgrind-check failure in https://northerntech.atlassian.net/browse/ENT-13720
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.