Made cf-remote install --demo generate a random password and salt#180
Open
olehermanse wants to merge 3 commits intocfengine:masterfrom
Open
Made cf-remote install --demo generate a random password and salt#180olehermanse wants to merge 3 commits intocfengine:masterfrom
olehermanse wants to merge 3 commits intocfengine:masterfrom
Conversation
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
larsewi
approved these changes
May 8, 2026
| '/var/cfengine/bin/psql cfsettings -f "{}"'.format(query), | ||
| ) | ||
| safe_host = strip_user(host).replace("/", "_").replace(":", "_") | ||
| rendered_path = os.path.join(cf_remote_dir(), "demo-{}.sql".format(safe_host)) |
Contributor
There was a problem hiding this comment.
This could cause a race condition when running parallel executions of cf-remote install --demo. Consider using tempfile.mkdtemp. This file should probably also be written with perms 0600.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.