Deploy cert-manager on Google Kubernetes Engine Tutorial - remove google domains - #2062
Conversation
cert-manager-prow
Bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
size/XS
|
Will squash and sign off once I've got this completed |
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
wallrj-cyberark
left a comment
wallrj-cyberark
left a comment
There was a problem hiding this comment.
Thank you for flagging this — the Google Domains references in the GKE tutorial are indeed broken since the service was sold to Squarespace in 2023.
The current state of this PR only removes the Google Domains mention from the prerequisites line (line 41), but Section 4 ("Create a domain name for your website") still contains the bulk of the Google Domains content: step-by-step instructions pointing at domains.google.com, three Google Domains screenshots, and references to the Google Domains cart and DNS management UI.
The "Last Verified" date was also bumped to 14 April 2026, but the tutorial was not actually re-verified — the Google Domains content that immediately follows is broken.
As you noted in the PR description, this needs a decision on whether to:
- Replace Google Domains with a different registrar, or
- Make the domain section generic (remove registrar-specific steps and screenshots, keep the general A-record instruction)
I would suggest option 2 — making it generic. Registrar-specific screenshots and step-by-step instructions become stale when the registrar changes its UI, and the important concept for readers is "create an A record pointing to your ingress IP", not "click this button in this registrar's dashboard." The three Google Domains screenshots in static/images/getting-started/ should be removed as part of this change.
The "Last Verified" date should only be bumped when the tutorial is actually walked through end-to-end.
Are you still planning to complete this work? If so, I am happy to review a follow-up. If not, please let us know and we can either pick it up or close the PR.
|
hey @wallrj-cyberark I'm picking this back up! Sorry for the delay, i'll go with option 2, to make those steps generic! |
cert-manager-prow
Bot
added
size/S
Signed-off-by: Seth McCombs <seth@greybeam.ai>
Signed-off-by: Seth McCombs <seth@greybeam.ai>
97c5ef8 to
1952c01
Compare
cert-manager-prow
Bot
added
dco-signoff: yes
| **💻 Domain Name** | ||
|
|
||
| You will need a domain name and the ability to create DNS records in that domain. We will be getting a $12 domain name from Google Domains. Google Domains is one of the many possible "domain name registrars". NameCheap and GoDaddy are two other well-known registrars. | ||
| You will need a domain name and the ability to create DNS records in that domain. NameCheap and GoDaddy are two well-known registrars that may be used to register your domain name. |
There was a problem hiding this comment.
do we want to call out any registrars here or just say something like "you can use any registrar"
cert-manager-prow
Bot
removed
the
do-not-merge/work-in-progress
2 participants
Fixes #2061
Removing
google domainsin favor ofWill make changes once discussion on above issue pans out one way or another