ocproxy: route HEAD requests on the /download endpoint#41
Open
SamuAlfageme wants to merge 1 commit intocernbox:masterfrom
Open
ocproxy: route HEAD requests on the /download endpoint#41SamuAlfageme wants to merge 1 commit intocernbox:masterfrom
SamuAlfageme wants to merge 1 commit intocernbox:masterfrom
Conversation
diocas
reviewed
Jan 11, 2022
Collaborator
There was a problem hiding this comment.
With HEAD you just want the metadata, right? Because the way you implemented it looks like we're still fetching the data from EOS and maybe we should not do that. Can you confirm?
So it might not be as simple as adding this small change.. Can't we wait for OCIS in production to fulfill this request? (But then this leads us to the other discussion on the pl urls :))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows fetching metadata (size, content-type, expiration, etc.) from a public link share without the need to download it:
(Internal feature request for reference INC3001203)