chore(lint): enable clippy::map_err_ignore#21
Open
tupe12334 wants to merge 1 commit into
Open
Conversation
Prevents .map_err(|_| ...) from silently discarding the source error in network, checksum, and archive-extraction paths. Closes #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enables
clippy::map_err_ignoreasdenyinlib/Cargo.toml. This restriction-group lint flags.map_err(|_| ...), which discards the source error instead of preserving it.Why
centy-installerhandles network requests, checksum verification, and archive extraction — failure-prone operations where the original error is exactly what's needed to debug a broken install. This lint stops future code from silently dropping that context.Verification
cargo clippy --all-targets— clean, zero violations (no existing.map_err(|_| ...)call sites inlib/src)cargo build— cleancargo test— 63 unit tests + 4 e2e tests passCloses #20
This pull request was opened by the Clippy lint improvements → issue + PR (Rust repos) → Slack routine of moadim.