chore(lint): enable clippy::allow_attributes_without_reason#13
Open
tupe12334 wants to merge 1 commit into
Open
chore(lint): enable clippy::allow_attributes_without_reason#13tupe12334 wants to merge 1 commit into
tupe12334 wants to merge 1 commit into
Conversation
Deny clippy::allow_attributes_without_reason in lib/Cargo.toml and add a reason = "..." to every existing #[allow(...)] site (test modules opting out of the panic-safety lints, plus the retained dead_code tag field). No production logic changes. Closes #11 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enables the
clippy::allow_attributes_without_reasonrestriction lint atdenylevel inlib/Cargo.toml, and adds areason = "..."to every existing#[allow(...)]/#![allow(...)]site.Why
This crate already denies a strong panic-safety set (
unwrap_used,expect_used,panic,indexing_slicing, …), but the suppressions that opt out carried no recorded justification. Requiring a reason makes every suppression self-documenting and auditable in review.Sites updated
download.rs,extract.rs,daemon.rs,github.rs,platform.rs,lib.rs,install.rs, and thetests/e2e_install.rsintegration test — all gainreason = "tests deliberately unwrap/panic to fail fast on broken fixtures".ReleaseInfo::tagdead_codeallow gainsreason = "retained for consumers that need the resolved tag".No production logic changes.
Verification
cargo clippy --manifest-path lib/Cargo.toml --all-targets -- -D warningsandcargo test --manifest-path lib/Cargo.tomlboth pass.Closes #11
🤖 Generated with Claude Code
This pull request was opened by the "Open issues → fix PRs (owned repos + my orgs)" routine of moadim.