Update Business Onboarding API docs to match implementation - #1385
Merged
Merged
Conversation
alexBinns
requested review from
Linlin-Liang,
bpal938,
chad-miller and
cwenborn
September 8, 2026 01:33
Documents fields and behavior added to createOnboardingRequest.route.js that had drifted from the published docs: sendInvitation, stakeholders, merchant redirectUrls/searchHidden, optional settlementAccountNumber/externalMerchantId, the new billingConfig/rates model, conditional deviceId requirement, and the LIVENESS_MISMATCH/BILLING_CONFIG_NOT_ALLOWED error codes. Also adds an e-commerce onboarding example alongside the existing physical merchant one. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
alexBinns
force-pushed
the
update-onboarding-api-docs
branch
from
September 9, 2026 01:00
38b97ff to
58e64b1
Compare
Drop the billingConfig field, Billing Config Model, Rate Model, and BILLING_CONFIG_NOT_ALLOWED error added in the previous commit. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bpal938
approved these changes
Sep 9, 2026
This reverts commit 6608087.
This reverts commit c067309.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The snapshot was stale because it was generated against a dist build that predated the billing config removal. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kari'screateOnboardingRequest.route.js: documents new request fields (sendInvitation,merchant.redirectUrls,merchant.searchHidden), correctssettlementAccountNumber/externalMerchantIdfrom required to optional, notesdeviceIdis only required whenvendorisn'tnomad, and adds theLIVENESS_MISMATCHerror code.redirectUrlsinstead oflocation.Manual test steps
LIVENESS_MISMATCHerror response renders correctly in the Error Responses list.🤖 Generated with Claude Code