Make csg levels optional and delete unused struct#21
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ORANGE output Pydantic models to accommodate upstream JSON output changes (making max_csg_levels optional) and removes an unused model, with corresponding test updates to validate the new behavior.
Changes:
- Make
OrangeScalars.max_csg_levelsoptional with a default ofNone. - Remove the unused
BihSizesmodel. - Replace the old BIH-size-specific test with a broader ORANGE output parsing test that exercises the optional field behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
celerpy/model/output.py |
Makes max_csg_levels optional and deletes the unused BihSizes model. |
test/test_model.py |
Updates tests to validate ORANGE output parsing when max_csg_levels is omitted. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for celeritas-project/celeritas#2413 .