Skip to content

Update BIH structure and names for upstream celeritas #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethrj merged 4 commits into from
May 29, 2026
Merged

Update BIH structure and names for upstream celeritas #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5f9231
Reapply "Add BIH structure"
sethrj May 29, 2026
239020b
Reapply "Update inner -> internal"
sethrj May 29, 2026
8b54de4
fixup! Reapply "Update inner -> internal"
sethrj May 29, 2026
f0269e9
Merge branch 'main' into bih-update
sethrj May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion celerpy/model/output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class BihSizes(_Model):
"""Bounding Interval Hierarchy tree sizes."""

bboxes: NonNegativeInt
inner_nodes: NonNegativeInt
internal_nodes: NonNegativeInt
Comment thread
sethrj marked this conversation as resolved.
leaf_nodes: NonNegativeInt
local_volume_ids: NonNegativeInt

Expand All @@ -79,6 +79,7 @@ class BihMetadata(_Model):
num_finite_bboxes: list[NonNegativeInt]
num_infinite_bboxes: list[NonNegativeInt]
depth: list[NonNegativeInt]
structure: Optional[list[dict]] = None


# orange/OrangeParamsOutput.hh
Expand Down
4 changes: 2 additions & 2 deletions test/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ def test_orange_stats_serialization():

def test_bih_load():
result = moutput.BihSizes.model_validate_json(
'{"bboxes":8,"inner_nodes":0,"leaf_nodes":1,"local_volume_ids":7}'
'{"bboxes":8,"internal_nodes":0,"leaf_nodes":1,"local_volume_ids":7}'
)
assert result == moutput.BihSizes(
bboxes=8, inner_nodes=0, leaf_nodes=1, local_volume_ids=7
bboxes=8, internal_nodes=0, leaf_nodes=1, local_volume_ids=7
)