Skip to content

Fix app token creation in reusable workflow #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mahendrapaipuri merged 3 commits into from
Jul 5, 2026
Merged

Fix app token creation in reusable workflow #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eefb6a5
ci: Debug app token creation
mahendrapaipuri Jul 5, 2026
d349173
ci: Make app private key secret available in reusable workflow
mahendrapaipuri Jul 5, 2026
2694842
ci: Revert changes to workflow file
mahendrapaipuri Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ jobs:
test-unit:
needs: [test-lint]
uses: ./.github/workflows/step_tests-unit.yml
secrets:
app_private_key: ${{ secrets.APP_UPDATE_README_HELPER_PRIVATE_KEY }}

test-e2e:
needs: [test-lint, test-unit]
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/step_tests-unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ run-name: Unit Tests

on:
workflow_call:
secrets:
app_private_key:
required: true

jobs:
unit-tests:
Expand Down Expand Up @@ -79,8 +82,8 @@ jobs:
id: app-token
if: steps.verify-changed-files.outputs.files_changed == 'true' && github.ref == 'refs/heads/main'
with:
app-id: 4221824
private-key: ${{ secrets.APP_UPDATE_README_HELPER_PRIVATE_KEY }}
client-id: 4221824
private-key: ${{ secrets.app_private_key }}

- name: Commit changes
if: steps.verify-changed-files.outputs.files_changed == 'true' && github.ref == 'refs/heads/main'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/update-citation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,19 +39,19 @@ jobs:
id: app-token
if: steps.verify-changed-files.outputs.files_changed == 'true' && github.ref == 'refs/heads/main'
with:
app-id: 4221824
client-id: 4221824
private-key: ${{ secrets.APP_UPDATE_README_HELPER_PRIVATE_KEY }}

- name: Commit changes
if: steps.verify-changed-files.outputs.files_changed == 'true' && && github.ref == 'refs/heads/main'
if: steps.verify-changed-files.outputs.files_changed == 'true' && github.ref == 'refs/heads/main'
run: |
git config --local user.email "bot@ceems.com"
git config --local user.name "CEEMS bot"
git add CITATION.cff
git commit -m "chore: Update version in CITATION.cff" -s

- name: Push changes
if: steps.verify-changed-files.outputs.files_changed == 'true' && && github.ref == 'refs/heads/main'
if: steps.verify-changed-files.outputs.files_changed == 'true' && github.ref == 'refs/heads/main'
uses: ad-m/github-push-action@master
with:
github_token: ${{ steps.app-token.outputs.token }}
Expand Down