refactor: Misc improvements and fixes for API server#549
Merged
Conversation
* Apply CORS headers for middleware as well. Until now, CORS headers are applied only for the requests that pass thru middleware. So, when header checks fail in middleware, CORS headers are missing in responses and hence browsers do not treat those responses correctly. Now CORS headers are applied to the middleware as well * Generate OAPI spec 3 for swagger docs. Need to replace upstream modules for Swagger UI to work correctly in our case. Add health endpoint to Swagger spec. Move API swagger docs folder out of http folder into api folder to be more consistent * Fix health endpoint in deployment docs Closes #548 Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply CORS headers for middleware as well. Until now, CORS headers are applied only for the requests that pass thru middleware. So, when header checks fail in middleware, CORS headers are missing in responses and hence browsers do not treat those responses correctly. Now CORS headers are applied to the middleware as well
Generate OAPI spec 3 for swagger docs. Need to replace upstream modules for Swagger UI to work correctly in our case. Add health endpoint to Swagger spec. Move API swagger docs folder out of http folder into api folder to be more consistent
Fix health endpoint in deployment docs
Closes #548