fix: add replay timelines for JIT and class charts#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finished run pages now give JIT Compilation and Class Loading the same replay affordance as Memory, GC, and Heap/RSS charts. Each section gets its own Play/Pause/Reset controls, speed selector, and timeline slider that scrubs both charts in the section together.
Before this, the new JIT/Class charts rendered only as static final-state charts on run detail pages, so users could not replay how compilation or class loading evolved over the build.
Verification
npm test -- --runInBandnode --check /private/tmp/run-page-script.jsVisual browser capture was not available in this session because the browser/Playwright tools were unavailable.