Skip to content

Api lambda cleanup3#2934

Open
P0NDER0SA wants to merge 9 commits into
mainfrom
api-lambda-cleanup3
Open

Api lambda cleanup3#2934
P0NDER0SA wants to merge 9 commits into
mainfrom
api-lambda-cleanup3

Conversation

@P0NDER0SA

@P0NDER0SA P0NDER0SA commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary | Résumé

This pull request removes support for running the application as an AWS Lambda function via API Gateway by eliminating the use of the apig-wsgi package and its related handler code. The application is now set up solely as a standard Flask app, simplifying deployment and reducing dependencies.

Dependency removal:

  • Removed the apig-wsgi package from the dependencies in pyproject.toml, as Lambda support is no longer needed.

Code cleanup and simplification:

  • Deleted all code related to Lambda support in application.py, including the import and usage of apig-wsgi, the is_lambda check, the apig_wsgi_handler, and the handler function. [1] [2] [3] [4]

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@P0NDER0SA P0NDER0SA requested a review from jimleroyer as a code owner July 7, 2026 13:53
Copilot AI review requested due to automatic review settings July 7, 2026 13:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes Lambda-container support (api-lambda) from the repo and CI/CD, standardizing builds/deployments around the Kubernetes (k8s) container image and simplifying the Python app to a pure Flask WSGI entrypoint.

Changes:

  • Removed Lambda handler logic from application.py and dropped the apig-wsgi dependency from pyproject.toml.
  • Deleted Lambda-specific GitHub Actions workflows and the Lambda Dockerfile, and updated shared workflows to build/scan/push only the k8s image.
  • Simplified workflow naming/steps to remove Lambda references.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Removes the apig-wsgi dependency as part of Lambda support removal.
application.py Removes Lambda handler/adapter code, leaving a standard Flask WSGI setup.
.github/workflows/dev_branch_build_push_images.yml Builds and pushes only the k8s (api) image for dev branch workflows.
.github/workflows/pr_docker_build_test.yml PR Docker build validation now focuses on the k8s image only.
.github/workflows/docker-vulnerability-scan.yml Vulnerability scanning targets only the k8s image.
.github/workflows/lambda_production.yml (deleted) Removes Lambda production build/deploy pipeline.
.github/workflows/lambda_staging.yml (deleted) Removes Lambda staging build/deploy pipeline.
ci/Dockerfile.lambda (deleted) Removes the ability to build the Lambda container image.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml

@ben851 ben851 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants