Api lambda cleanup3#2934
Open
P0NDER0SA wants to merge 9 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes Lambda-container support (api-lambda) from the repo and CI/CD, standardizing builds/deployments around the Kubernetes (k8s) container image and simplifying the Python app to a pure Flask WSGI entrypoint.
Changes:
- Removed Lambda handler logic from
application.pyand dropped theapig-wsgidependency frompyproject.toml. - Deleted Lambda-specific GitHub Actions workflows and the Lambda Dockerfile, and updated shared workflows to build/scan/push only the k8s image.
- Simplified workflow naming/steps to remove Lambda references.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pyproject.toml |
Removes the apig-wsgi dependency as part of Lambda support removal. |
application.py |
Removes Lambda handler/adapter code, leaving a standard Flask WSGI setup. |
.github/workflows/dev_branch_build_push_images.yml |
Builds and pushes only the k8s (api) image for dev branch workflows. |
.github/workflows/pr_docker_build_test.yml |
PR Docker build validation now focuses on the k8s image only. |
.github/workflows/docker-vulnerability-scan.yml |
Vulnerability scanning targets only the k8s image. |
.github/workflows/lambda_production.yml (deleted) |
Removes Lambda production build/deploy pipeline. |
.github/workflows/lambda_staging.yml (deleted) |
Removes Lambda staging build/deploy pipeline. |
ci/Dockerfile.lambda (deleted) |
Removes the ability to build the Lambda container image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This pull request removes support for running the application as an AWS Lambda function via API Gateway by eliminating the use of the
apig-wsgipackage and its related handler code. The application is now set up solely as a standard Flask app, simplifying deployment and reducing dependencies.Dependency removal:
apig-wsgipackage from the dependencies inpyproject.toml, as Lambda support is no longer needed.Code cleanup and simplification:
application.py, including the import and usage ofapig-wsgi, theis_lambdacheck, theapig_wsgi_handler, and thehandlerfunction. [1] [2] [3] [4]Reviewer checklist | Liste de vérification du réviseur