Fixing docker internal hosts (option 2)#1987
Closed
amazingphilippe wants to merge 1 commit into
Closed
Conversation
…etworks, updated pyproject packages
🧪 Review environmenthttps://4pedgxk25wwkn6emfpdkqe57zm0mhytd.lambda-url.ca-central-1.on.aws/ |
Contributor
Author
|
Closing this for #1986 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This will need a proper review. While it works, I'm not sure why.
Essentially, this PR should use docker-compose.yml to make sure we use a new "notification-network" in both api and admin ymls. See related PR here: cds-snc/notification-api#2340
Did I configure Dockerfile, devcontainer.json properly? I doubt it.
Additionally, when opening this container, Poetry complained about not being able to install "notification-admin". Possibly because packages is empty in pyproject.toml? Again, please code check me!
Test instructions | Instructions pour tester la modification