Skip to content

chore(deps): upgrade dependencies - #1914

Merged
rix0rrr merged 3 commits into
mainfrom
github-actions/upgrade-main
Jul 18, 2026
Merged

rix0rrr merged 3 commits into
mainfrom
github-actions/upgrade-main

Conversation

@cdklabs-automation

@cdklabs-automation cdklabs-automation commented Jun 23, 2026 •

Copy link
Copy Markdown
Collaborator

Upgrades project dependencies. See details in workflow run.


Automatically created by projen via the "upgrade-main" workflow

@cdklabs-automation
cdklabs-automation added this pull request to the merge queue Jun 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 23, 2026
@cdklabs-automation
cdklabs-automation force-pushed the github-actions/upgrade-main branch from a1a0c48 to 75865f7 Compare June 29, 2026 01:09
@cdklabs-automation
cdklabs-automation force-pushed the github-actions/upgrade-main branch from 75865f7 to 02df97a Compare July 6, 2026 00:55
@rix0rrr
rix0rrr enabled auto-merge July 7, 2026 12:14
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/construct-hub-webapp/actions/runs/29216000491

------

*Automatically created by projen via the "upgrade-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@cdklabs-automation
cdklabs-automation force-pushed the github-actions/upgrade-main branch from 02df97a to 0fde3e9 Compare July 13, 2026 00:48
react-scripts test rejects the `collectCoverage` key in package.json's
jest config (CRA only whitelists a fixed set of Jest overrides, which
includes collectCoverageFrom but not collectCoverage), which was failing
the build test step. Remove the field in .projenrc.ts and regenerate.
The previous commit inadvertently removed the "compile" script entry
while editing package.json. Restore it so the file matches projen's
generated output (npx projen produces no diff).
@sanjanaravikumar-az

Copy link
Copy Markdown
Contributor

Root Cause

The build check was failing at the test step (react-scripts test), not at compilation — compilation succeeded. Create React App only honors a fixed whitelist of Jest overrides declared in package.json (it allows collectCoverageFrom, but not collectCoverage). The generated package.json carried a jest.collectCoverage field, so react-scripts test aborted before running any tests:

These options in your package.json Jest configuration are not currently supported by Create React App:

  • collectCoverage

This is deterministic, so re-running CI did not help.

Fix: removed the collectCoverage field from the Jest config in .projenrc.ts and regenerated (npx projen). Validated locally: npx projen build passes (12 test suites / 74 tests green) and npx projen is idempotent (no self-mutation drift). No coverage threshold/gate or upload consumes this setting, so removing it has no functional impact — coverage can still be produced on demand via react-scripts test --coverage.

Side note (not required for this fix): rewireCRA() in .projenrc.ts intends to swap react-scripts → react-app-rewired for the build/test/dev tasks, but the generated tasks now use array-form execArgs, so the step.exec check no longer matches and the swap silently no-ops. Worth a separate follow-up.

@rix0rrr
rix0rrr added this pull request to the merge queue Jul 18, 2026
Merged via the queue into main with commit 2730a20 Jul 18, 2026
7 checks passed
@rix0rrr
rix0rrr deleted the github-actions/upgrade-main branch July 18, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants