1023: Ensure UTF Support#1729
Open
DmitryMK wants to merge 7 commits into
Open
Conversation
RamilCDISC
requested changes
Jun 11, 2026
RamilCDISC
left a comment
Collaborator
There was a problem hiding this comment.
JsonReport.write_report() still uses a with open(self._output_name, "w") and json.dump(report_data, f) without explicit encoding or ensure_ascii=False the json.dump ensure_ascii defaults to True. This can escape non ASCII characters instead of writing them as it is.
Collaborator
There was a problem hiding this comment.
Could we please move this test under regression testing instead? Regression testing folder has similar tests where we run the engine using subprocess.
RamilCDISC
approved these changes
Jun 12, 2026
RamilCDISC
left a comment
Collaborator
There was a problem hiding this comment.
The PR ensures UTF-8 encoding for writing the reports and that non-asciii characters are handled properly. The PR was validated by:
- Reviewing the PR for any unwanted code or comments.
- Reviewing the PR in accordance with AC.
- Ensuring all unit and regression testing pass.
- Ensuring the testing is placed in proper pace and covers the AC.
- Ensuring the report writing defaults to 'UTF-8'
- Ensuring both formats (excel and json) both reports handle multilingual characters and non-ASCII characters.
- Ensuring non-ASCII characters are displayed and intractable in reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1023