Skip to content

1023: Ensure UTF Support#1729

Open
DmitryMK wants to merge 7 commits into
mainfrom
1023-Ensure-UTF-Support
Open

1023: Ensure UTF Support#1729
DmitryMK wants to merge 7 commits into
mainfrom
1023-Ensure-UTF-Support

Conversation

@DmitryMK

Copy link
Copy Markdown
Collaborator

Addresses #1023

  • Added tests to verify that reporting service support UTF in both Excel and JSON.
  • Added additional tests to check different encodings (latin1, cp1252, utf8) are reported correctly.

@gerrycampion gerrycampion added this to the v1.0.0 milestone Jun 11, 2026
@gerrycampion gerrycampion linked an issue Jun 11, 2026 that may be closed by this pull request

@RamilCDISC RamilCDISC left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JsonReport.write_report() still uses a with open(self._output_name, "w") and json.dump(report_data, f) without explicit encoding or ensure_ascii=False the json.dump ensure_ascii defaults to True. This can escape non ASCII characters instead of writing them as it is.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please move this test under regression testing instead? Regression testing folder has similar tests where we run the engine using subprocess.

@RamilCDISC RamilCDISC left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR ensures UTF-8 encoding for writing the reports and that non-asciii characters are handled properly. The PR was validated by:

  1. Reviewing the PR for any unwanted code or comments.
  2. Reviewing the PR in accordance with AC.
  3. Ensuring all unit and regression testing pass.
  4. Ensuring the testing is placed in proper pace and covers the AC.
  5. Ensuring the report writing defaults to 'UTF-8'
  6. Ensuring both formats (excel and json) both reports handle multilingual characters and non-ASCII characters.
  7. Ensuring non-ASCII characters are displayed and intractable in reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure UTF Support in Report Generator

3 participants