Requirements#55
Merged
Merged
Conversation
RamilCDISC
requested changes
Jun 15, 2026
| echo "Installing standard requirements..." | ||
| pip install -r engine/requirements-dev.txt --quiet | ||
| echo "Installing standard requirements..." | ||
| pip install --quiet -e engine/[dev] |
Contributor
There was a problem hiding this comment.
Current engine in the repo defines a 'dev' dependency group instead of dev extra. Here it seems like it is trying to install a dev extra. Please let me know if I am confusing something.
Collaborator
Author
There was a problem hiding this comment.
that is the [dev] devependency group in the pyproject.toml file
RamilCDISC
approved these changes
Jun 15, 2026
RamilCDISC
left a comment
RamilCDISC
left a comment
Contributor
There was a problem hiding this comment.
The PR updates the installation scripts as pyproject.toml of rules engine is updated. The updated scripts were validated for:
- Correct syntax.
- Consistency across different scripts.
- Any dead/old code remaining after update.
- bash and windows scripts install same level of dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR updates the installation script and action to reflect the new toml file usage for dependencies