Skip to content

Network#480

Draft
cdalar wants to merge 31 commits into
mainfrom
network
Draft

Network#480
cdalar wants to merge 31 commits into
mainfrom
network

Conversation

@cdalar

@cdalar cdalar commented Aug 12, 2024

Copy link
Copy Markdown
Owner

No description provided.

@CLAassistant

CLAassistant commented Feb 5, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@cdalar cdalar marked this pull request as ready for review August 16, 2025 18:14
@cdalar cdalar requested a review from Copilot August 16, 2025 18:14

This comment was marked as outdated.

cdalar and others added 4 commits August 16, 2025 20:16
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@codecov

codecov Bot commented Sep 3, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 10.15707% with 858 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.76%. Comparing base (fc3e52e) to head (da8d33a).
⚠️ Report is 174 commits behind head on main.

Files with missing lines Patch % Lines
internal/cloud/hetzner.go 8.44% 141 Missing ⚠️
internal/cloud/aws.go 0.00% 126 Missing ⚠️
cmd/network.go 5.50% 103 Missing ⚠️
cmd/templates.go 1.19% 83 Missing ⚠️
cmd/vm.go 7.86% 82 Missing ⚠️
internal/provideraws/common.go 0.00% 60 Missing ⚠️
internal/tools/scp.go 57.14% 40 Missing and 8 partials ⚠️
cmd/create.go 2.17% 45 Missing ⚠️
cmd/ssh.go 2.50% 39 Missing ⚠️
internal/tools/remote-run.go 0.00% 39 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff            @@
##            main     #480      +/-   ##
=========================================
+ Coverage   8.23%   10.76%   +2.52%     
=========================================
  Files         31       34       +3     
  Lines       3036     3856     +820     
=========================================
+ Hits         250      415     +165     
- Misses      2764     3411     +647     
- Partials      22       30       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cdalar cdalar requested a review from Copilot September 5, 2025 17:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds comprehensive jumphost support and network management capabilities to the onctl cloud management tool. The PR enables connecting to VMs through jump hosts for secure access patterns and provides full network lifecycle management across cloud providers.

  • Implements SSH ProxyJump functionality for secure VM access through jump hosts
  • Adds network resource management with CRUD operations for AWS and Hetzner
  • Enhances VM listing to only show running instances across all providers

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
internal/tools/ssh.go Adds jumphost support to SSH connections using ProxyJump
internal/tools/scp.go Implements jumphost functionality for SCP file transfers
internal/tools/remote-run.go Adds jumphost support for remote SSH connections
internal/provideraws/common.go Adds GetLatestUbuntu2204AMI function with dynamic AMI selection
internal/cloud/hetzner.go Adds network management and filters VM list to running instances
internal/cloud/gcp.go Filters VM list to running instances and adds stub network methods
internal/cloud/cloud.go Adds network management interfaces and jumphost VM field
internal/cloud/azure.go Filters VM list to running instances and adds stub network methods
internal/cloud/aws.go Adds network management and filters VM list to running instances
cmd/vm.go New command for VM network attach/detach operations
cmd/ssh.go Adds jumphost resolution and IP selection logic
cmd/root.go Initializes network managers for supported providers
cmd/network.go New command for network CRUD operations
cmd/create.go Adds jumphost support for VM creation and domain registration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread internal/tools/scp.go Outdated
Comment thread internal/cloud/aws.go
Comment thread cmd/ssh.go
@socket-security

socket-security Bot commented Sep 5, 2025

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedgolang/​github.com/​charmbracelet/​glamour@​v0.10.0100100100100100

View full report

configuration examples
- Updated golang.org/x/net to v0.43.0 from main
- Kept golang.org/x/image dependency for go-term-markdown
- Resolved go.mod conflicts
- Remove github.com/MichaelMure/go-term-markdown dependency
- Add github.com/charmbracelet/glamour v0.10.0 dependency
- Update templates.go to use glamour.NewTermRenderer with auto-style detection
- Improve markdown rendering with better terminal compatibility
- Tested with onctl templates describe azure command
cdalar and others added 9 commits September 18, 2025 22:48
…ot review)

- hetzner.go: replace log.Fatalln with return err in Delete, Create,
  DetachNetwork, AttachNetwork; make NetworkZone configurable via
  hetzner.network_zone config key (falls back to EU-Central)
- aws.go: replace log.Fatalln/log.Fatalf with return error in Create
  and Delete; move ParseCIDR error check before nil-deref on ipNet
- scp.go: extract writeTempKeyFile helper to remove duplication between
  downloadFileWithJumpHost and uploadFileWithJumpHost

https://claude.ai/code/session_011r5c4HXBEiFL7vvrjQubWS
@cdalar cdalar enabled auto-merge (squash) June 5, 2026 08:01
@cdalar cdalar marked this pull request as draft June 20, 2026 06:13
auto-merge was automatically disabled June 20, 2026 06:13

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants