Exclude non-actionable blocked claim modes from dashboard 'today' group#228
Merged
Conversation
…' group Chores in NOT_MY_TURN, STANDBY (blocked), and PAUSED claim modes were being grouped into 'today' or 'this_week' based on their due date, even though the assignee cannot act on them. This caused the dashboard group headers to show inflated counts compared to the welcome card summary. Adds a 'claim_mode' parameter to _calculate_primary_group() that routes these non-actionable chores to the 'other' group instead, matching the filtering already done in chore_counts_toward_due_today_summary(). Refs #205
ccpk1
added
bug
The pyproject.toml ignore list used the old string-style rule name 'too-many-positional-arguments' which is no longer recognized by ruff 0.15+. Replaced with the proper rule code 'PLR0917'.
- Pin ruff to 0.15.16 in both CI (pip install ruff==0.15.16) and locally (pyproject.toml required-version ==0.15.16) to prevent version drift - Add PLR0917 to ruff's ignore list (was previously only in the pylint disable section, which has no effect on ruff) so the CI doesn't flag button.py constructor signatures - Revert the pylint section back to string-style rule names (pylint uses human-readable names, not ruff codes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chores in
NOT_MY_TURN,STANDBY(blocked), andPAUSEDclaim modes were being grouped intotodayorthis_weekbased on their due date, even though the assignee cannot act on them. This caused the dashboard group headers to show inflated counts compared to the welcome card summary.Changes
_calculate_chore_attributes): Extractclaim_modefrom the status context and pass it to_calculate_primary_group._calculate_primary_group): Addedclaim_modeparameter. When the mode isblocked_not_my_turn,blocked_standby, orblocked_paused, returnotherinstead of routing via due-date-based grouping.otherwhile overdue, is_due, and non-blocked modes remain unchanged.Related Issues
Refs #205