Route deploy recovery through authorized reusable identity - #2173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
launchplane_url, stripping it before the service payloadWhy
Two read-only dispatches proved the caller workflow path alone is not sufficient for Launchplane authz:
launchplane_req_57ec813d76434e6195d53b93848ce44claunchplane_req_d45aac5be8e348b2943d13f942cc2acbThe existing stable-deploy reusable workflow identity is authorized and reached Launchplane with
409 mutation_in_progress. This change reuses that exact identity without changing authz policy.Safety
recovery_request_jsonskips the stable-deploy job/v1/admin/generic-web/deploy-recovery/dry-runValidation
actionlint .github/workflows/reusable-generic-web-stable-deploy.ymlnode --checkgit diff --checkRelated: #2167