Skip to content

Make webhook lock tests causal - #592

Merged
cbusillo merged 1 commit into
mainfrom
audit/limit-warning-test-gates
Aug 12, 2026
Merged

Make webhook lock tests causal#592
cbusillo merged 1 commit into
mainfrom
audit/limit-warning-test-gates

Conversation

@cbusillo

Copy link
Copy Markdown
Owner

Summary

  • replace private webhook test polling loops with bounded continuation-backed gates
  • split the timing-dependent concurrent writer test into deterministic held-lock refusal and shared-state contracts
  • retain and document the one snapshot-read sensitivity delay that lacks a production observer seam
  • guarantee held-lock and spawned-task cleanup on throwing paths

Refs #578

Validation

  • swift test --filter limitWarningWebhook (21 passed)
  • 20 repeated focused stability runs passed
  • lock-bypass mutation: removing sendTest locking failed the held-lock test on delivery, POST, and state assertions
  • python3 scripts/context-panel-test-lanes.py time-command --lane routine-ci-swift -- swift test (891 passed)
  • scripts/commit-gate.sh
  • JetBrains changed-files inspection: GREEN, 0 findings
  • Opus and Gemini exact-SHA final reviews approved 3ca57eb

Scope

  • test-only change in Tests/ContextPanelCoreTests/LimitWarningTests.swift
  • no production lock or webhook behavior changed

@cbusillo
cbusillo merged commit ccd75e9 into main Aug 12, 2026
4 checks passed
@cbusillo
cbusillo deleted the audit/limit-warning-test-gates branch August 12, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant