Skip to content

Align screenshot workflow choices - #587

Merged
cbusillo merged 1 commit into
mainfrom
fix/screenshot-workflow-parity
Aug 12, 2026
Merged

Align screenshot workflow choices#587
cbusillo merged 1 commit into
mainfrom
fix/screenshot-workflow-parity

Conversation

@cbusillo

Copy link
Copy Markdown
Owner

Summary

  • expose the existing iphone65 approved screenshot set in the manual upload workflow
  • assert exact membership parity between workflow choices and script-supported sets
  • reject duplicate workflow choices and preserve the safe macos first choice
  • replace ambiguous per-option substring assertions with a fail-loud scoped helper

Evidence

  • the new parity test was observed failing before the workflow fix because iphone65 was missing
  • 145 targeted screenshot/workflow tests passed after the fix
  • all 10 routine Python lane files passed
  • actionlint .github/workflows/upload-app-store-screenshots.yml passed
  • scripts/commit-gate.sh passed, including all 889 Swift tests
  • Opus final review approved
  • Gemini final route was invoked but returned no usable review text

Refs #579

@cbusillo
cbusillo merged commit 130d4e8 into main Aug 12, 2026
4 checks passed
@cbusillo
cbusillo deleted the fix/screenshot-workflow-parity branch August 12, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant