Restore hermetic app-server integration keyring - #493
Merged
cbusillo merged 3 commits intoJul 29, 2026
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex app-serverintegration launches through one fail-closed keyring setup pathValidation
cargo fmt --all -- --checkcargo test -p codex-app-server --test all suite::keyring_store:: -- --nocapturecargo test -p codex-cli --test app_server -- --nocapturecargo check -p app_test_support -p codex-app-server -p codex-cli --tests --releaseScope
This restores the previously merged PR #351 acceptance behavior on the current #465 candidate. The implementation plus its spawn wiring and cross-process proof are one coherent debug-only acceptance patch; splitting would leave either unused infrastructure or an unprotected test path.
Closes the remaining test-isolation acceptance gap in #306.