Skip to content

Remove free-form analytics error subreason - #472

Merged
shiny-code-bot merged 1 commit into
mainfrom
code/analytics-error-subreason-429
Jul 25, 2026
Merged

Remove free-form analytics error subreason#472
shiny-code-bot merged 1 commit into
mainfrom
code/analytics-error-subreason-429

Conversation

@shiny-code-bot

Copy link
Copy Markdown
Collaborator

Why

Invalid-request response text can contain provider- or user-derived content. Copying that text into the free-form codex_error_subreason telemetry field creates unnecessary privacy risk when the existing structured error category already provides the diagnostic signal we need.

What changed

  • Remove codex_error_subreason from analytics fact construction, event serialization, and reducer plumbing.
  • Remove the 512-byte invalid-request text truncation helper and its unused constant.
  • Update analytics fixtures and assertions so invalid-request text is absent while structured error reporting remains intact.

Validation

  • cargo test -p codex-analytics — 71 tests passed.
  • Repository search confirms there is no remaining runtime emission path for codex_error_subreason.

Closes #429

@shiny-code-bot
shiny-code-bot merged commit 82ffbe8 into main Jul 25, 2026
10 checks passed
@shiny-code-bot
shiny-code-bot deleted the code/analytics-error-subreason-429 branch July 25, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop emitting free-form analytics error subreason

2 participants