Remove free-form analytics error subreason - #472
Merged
Conversation
6 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Invalid-request response text can contain provider- or user-derived content. Copying that text into the free-form
codex_error_subreasontelemetry field creates unnecessary privacy risk when the existing structured error category already provides the diagnostic signal we need.What changed
codex_error_subreasonfrom analytics fact construction, event serialization, and reducer plumbing.Validation
cargo test -p codex-analytics— 71 tests passed.codex_error_subreason.Closes #429