Consume generated Odoo workspaces safely - #467
Merged
Merged
Conversation
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--workspace-rootsupport for exact workspace-write roots across exec, interactive, and native child-session startup--add-dir, non-workspace sandboxes, and dangerous sandbox bypassplatform workspace status --check, verifies exact Codex Lab provenance, and records launch evidenceDesign Note
The issue originally proposed passing editable roots through
--add-dir. That keeps the launch CWD writable, which is too broad for generated workspaces. This change adds a generic exact-root primitive instead; Odoo detection and provider authority remain isolated in the adapter/harness layer.Validation
just fmtpython3 -m unittest discover -s tools/codex-exec-harness -p 'test_*.py'— 111 passedcargo test -p codex-utils-cli -p codex-prompts --lib— 52 passedcargo test -p codex-core explicit_workspace_roots_replace_cwd_for_workspace_write -- --nocapturecargo test -p codex-core session_permission_profile_rebinds_exact_runtime_workspace_roots -- --nocapturegenerated-odoo-workspace-consumptionscenario against the clean candidate42d8c7be84612871de479ca2db0d6c616fc169e1Safety Review
Closes #360