Skip to content

Fix protected GitHub run waiting diagnostics - #440

Merged
cbusillo merged 1 commit into
mainfrom
fix/gh-run-wait-protected-environment
Jul 26, 2026
Merged

Fix protected GitHub run waiting diagnostics#440
cbusillo merged 1 commit into
mainfrom
fix/gh-run-wait-protected-environment

Conversation

@shiny-code-bot

Copy link
Copy Markdown
Collaborator

Summary

  • add a native cross-platform gh_run_wait tool that detects GitHub Actions waiting status immediately
  • inspect exact-run pending deployments and report environment approval capability without mutating approvals
  • enforce one bounded deadline across run selection, polling, and active gh commands, with process-group cleanup and reaping
  • harden the shell fallback with exact --commit selection, bounded commands, signal cleanup, and regression coverage

Root cause

The previous generic waiter treated status=waiting as ordinary nonterminal progress. It never queried pending_deployments, so a protected-environment approval could remain invisible until an operator noticed the stalled run manually.

Validation

  • bash scripts/tests/wait-for-gh-run-test.sh
  • cargo test -p codex-core gh_run_wait
  • ./build-fast.sh

@cbusillo
cbusillo merged commit f98be98 into main Jul 26, 2026
1 check passed
@cbusillo
cbusillo deleted the fix/gh-run-wait-protected-environment branch July 26, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants