fix(core): preserve terminal subagent errors - #439
Closed
shiny-code-bot wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TurnCompleteandTurnAbortedeventsErroredstatus before terminal event delivery, including legacy errors without typed metadataContext
Current
mainalready distinguishes retryableStreamErrorevents from fatal errors. The remaining failure mode was manager-level reconciliation: a fatalErrorEventcould be overwritten by the generic trailingTurnComplete(None), making a failed child look like an empty success.This ports the relevant terminal-error precedence behavior from upstream while adapting it to this fork's current event-delivery and direct-parent notification paths.
Validation
just fmtcargo test -p codex-core multi_agent_v2_terminal_error_queues_message_for_direct_parent --lib -- --nocapturecargo test -p codex-core --test all multi_agent_v2_terminal_stream_error_preserves_errored_status -- --nocapturecargo test -p codex-core agent::control::tests --lib -- --test-threads=1 --nocapturecargo test -p codex-core --test all suite::subagent_notifications -- --test-threads=1 --nocapture./build-fast.shgit diff --checkJetBrains closeout inspection reported no problems, but its verdict was inconclusive because the configured IntelliJ instance did not provide semantic Rust coverage.
Refs #434