Repository navigation
Release 0.5.5: fix isLoading after OAuth in Strict Mode, link the Stellar wallet starter - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.5.5. CI publishes it on merge.
Fix:
isLoadingstuck attrueafter OAuth sign-in in React Strict Mode. In Strict Mode (the Next.js dev default) the OAuth callback effect runs, is cleaned up, and runs again. The cleanup setcancelled, so the first run never clearedisLoading; the second run found the code already removed from the URL and returned. Sign-in finished, but any app showing a spinner whileisLoadinghung. The callback is single-use, so the effect no longer cancels on cleanup. Tested in a local Next.js 16 app on testnet with this build.Also in this release: React Native marked as a work in progress in the README and the npm description (merged in #56), and the README and the Stellar skill link the Stellar wallet starter.
Tests: 548 pass.