Skip to content

Release 0.5.5: fix isLoading after OAuth in Strict Mode, link the Stellar wallet starter - #57

Merged
adrianvrj merged 3 commits into
mainfrom
fix/oauth-callback-loading
Nov 13, 2026
Merged

adrianvrj merged 3 commits into
mainfrom
fix/oauth-callback-loading

Conversation

@adrianvrj

@adrianvrj adrianvrj commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Release 0.5.5. CI publishes it on merge.

Fix: isLoading stuck at true after OAuth sign-in in React Strict Mode. In Strict Mode (the Next.js dev default) the OAuth callback effect runs, is cleaned up, and runs again. The cleanup set cancelled, so the first run never cleared isLoading; the second run found the code already removed from the URL and returned. Sign-in finished, but any app showing a spinner while isLoading hung. The callback is single-use, so the effect no longer cancels on cleanup. Tested in a local Next.js 16 app on testnet with this build.

Also in this release: React Native marked as a work in progress in the README and the npm description (merged in #56), and the README and the Stellar skill link the Stellar wallet starter.

Tests: 548 pass.

@adrianvrj adrianvrj changed the title Fix isLoading stuck at true after OAuth sign-in in Strict Mode Fix isLoading after OAuth in Strict Mode; link the Stellar wallet starter Nov 13, 2026
@adrianvrj adrianvrj changed the title Fix isLoading after OAuth in Strict Mode; link the Stellar wallet starter Release 0.5.5: fix isLoading after OAuth in Strict Mode, link the Stellar wallet starter Nov 13, 2026
@adrianvrj
adrianvrj merged commit fd5903d into main Nov 13, 2026
2 checks passed
@adrianvrj
adrianvrj deleted the fix/oauth-callback-loading branch November 13, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant