Update module github.com/docker/docker to v28 - #69
Conversation
Kimchi Code Review
Summary📊 Review Score: 68/100 (overall code quality — 0 lowest, 100 highest) 🧪 Tests: no — No tests were added, modified, or are visible in this PR to validate compatibility with the major version upgrade of 📝 Found 2 issue(s). See inline comments for details. What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
![kimchi-review[bot]](https://avatars.githubusercontent.com/in/3223788?s=60&v=4){kind=small}
There was a problem hiding this comment.
📊 Review Score: 68/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 2/5 (1 = trivial, 5 = very complex)
🧪 Tests: no — No tests were added, modified, or are visible in this PR to validate compatibility with the major version upgrade of github.com/docker/docker from v27.5.1 to v28.5.2.
📝 Found 2 issue(s). See inline comments for details.
| @@ -7,7 +7,7 @@ require ( | |||
| github.com/containerd/containerd/v2 v2.2.5 | |||
There was a problem hiding this comment.
This PR performs a major version upgrade of the direct dependency github.com/docker/docker from v27.5.1+incompatible to v28.5.2+incompatible without any accompanying source code or test changes. Docker v28 can introduce breaking API changes compared to v27, and without verifying usage sites, the project may fail to compile or behave incorrectly at runtime.
💡 Suggestion: Confirm that all usages of github.com/docker/docker client types and methods in the codebase are compatible with v28. Run go build ./... and the full test suite. If the upgrade passes, add or update an integration/unit test that exercises Docker client code paths to catch future regressions.
| github.com/containerd/platforms v1.0.0-rc.2 | ||
| github.com/distribution/reference v0.6.0 | ||
| github.com/docker/docker v27.5.1+incompatible | ||
| github.com/docker/docker v28.5.2+incompatible |
There was a problem hiding this comment.
Because github.com/docker/docker is a direct require dependency used for image analysis, a major version bump warrants targeted test coverage. The PR provides no evidence that the upgraded dependency has been exercised in CI or that Docker-specific code paths still pass.
💡 Suggestion: Ensure CI runs go test ./... after go mod tidy, and consider adding a test that invokes the Docker client code paths affected by this upgrade (e.g., image pull, inspect, or registry interaction) before merging.
This PR contains the following updates:
v27.5.1+incompatible→v28.5.2+incompatibleRelease Notes
docker/docker (github.com/docker/docker)
v28.5.2+incompatibleCompare Source
v28.5.1+incompatibleCompare Source
v28.5.0+incompatibleCompare Source
v28.4.0+incompatibleCompare Source
v28.3.3+incompatibleCompare Source
v28.3.2+incompatibleCompare Source
v28.3.1+incompatibleCompare Source
v28.3.0+incompatibleCompare Source
v28.2.2+incompatibleCompare Source
v28.2.1+incompatibleCompare Source
v28.2.0+incompatibleCompare Source
v28.1.1+incompatibleCompare Source
v28.1.0+incompatibleCompare Source
v28.0.4+incompatibleCompare Source
v28.0.3+incompatibleCompare Source
v28.0.2+incompatibleCompare Source
v28.0.1+incompatibleCompare Source
v28.0.0+incompatibleCompare Source
Configuration
📅 Schedule: (UTC)
* 0-3 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.