fix(530): add word-boundary check to @for and @if directive detection#549
Open
edward3h wants to merge 2 commits into
Open
fix(530): add word-boundary check to @for and @if directive detection#549edward3h wants to merge 2 commits into
edward3h wants to merge 2 commits into
Conversation
URLs containing @for or @if (e.g. @FortAwesome) were incorrectly parsed as JTE directives because regionMatches() matched the keyword without checking the following character. Require the next char to be '(' or whitespace, consistent with how @else already guards against @elseif.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
=========================================
Coverage 91.17% 91.17%
- Complexity 1223 1227 +4
=========================================
Files 76 76
Lines 3185 3185
Branches 489 489
=========================================
Hits 2904 2904
Misses 173 173
Partials 108 108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URLs containing @for or @if (e.g. @FortAwesome) were incorrectly parsed as JTE directives because regionMatches() matched the keyword without checking the following character. Require the next char to be '(' or whitespace, consistent with how @else already guards against @elseif.