Skip to content

Detach commands: cleanup needed #43

Description

@casey-c

The implementation of the detach() command (pressing N to 'delete' a node) is very messy at the moment. I followed the interface design I had developed with the previous add() and select() command families, thinking that I might need more types of subclassed commands that use it. This was not the case as I only have the one command so far (I can maybe think of another - perhaps a command to mimic a removeAndSaveOrphans() instead of just the removeAndBurnTheOrphange() command I have now), so the interface is kind of unnecessary abstraction.

Additionally, I made too many helper functions to accommodate this new feature, so the implementation is spread out far too much for my liking.

Further, I need to reexamine the recentNodes list mechanic to see if I can rename and better document why these two lists are necessary and how they should be used.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions