chore: release 0.14.5 with the Ruby state warning parity row - #34
Merged
Conversation
The row said the Ruby gem has no soft threshold. It carries the same solid_objects.state.large event from 0.14.3, as warn_state_bytes, and the same 5 MB hard default. Its threshold defaults to 64 KB rather than 128 KB, because the measured Ruby curve falls sooner: the gem keeps 55% of its empty-state throughput at 13 KB of state, where this package keeps 98% at 16 KB.
Greptile SummaryUpdates the parity ledger to record the Ruby implementation of large committed-state warnings and explain why its warning threshold differs from the JavaScript package.
Confidence Score: 5/5The documentation-only change appears safe to merge after the stated Ruby dependency is merged. The JavaScript event name, post-commit timing, limits, and benchmark statement are supported by repository code and documentation, and no changed-code defect or rule violation remains. Important Files Changed
Reviews (1): Last reviewed commit: "docs: record the Ruby state warning in t..." | Re-trigger Greptile |
A parity ledger correction with no runtime change, so this is a patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The port this repo already shipped in
0.14.4now exists on the Ruby side, sothe parity ledger row is stale. It says the Ruby gem "has no soft threshold
yet" and points at cardmagic/solid-objects-ruby#57, which is fixed by
cardmagic/solid-objects-ruby#58.
What changed
docs/parity.md, one row. "Large committed state warning" now records that theRuby gem carries the same
solid_objects.state.largeevent and the same 5 MBhard default from
0.14.3, underwarn_state_bytes, and that its thresholddefaults to 64 KB rather than 128 KB.
The defaults differ on purpose. Each is taken from its own measured curve: the
gem keeps 55% of its empty-state throughput at 13 KB of state, where this
package keeps 98% at 16 KB. Sharing one number would either warn a Node
application too early or warn a Rails application too late.
Version 0.14.5, a patch. The ledger correction carries no runtime change, so
package.json,src/version.ts, andCHANGELOG.mdmove together the way0.14.4did.No source change beyond the version constant. Nothing else in the ledger was
stale: the Ruby gem also cut its per-turn state copies and stopped encoding a
discarded string, but those are internal costs rather than ledger capabilities.
The remaining table lines in the diff are Prettier re-padding the column to the
new width.
Merge order
Merge after cardmagic/solid-objects-ruby#58, which is what makes the Ruby claim
in this row true.
Validation