Skip to content

Use the library's calibration file implementations - #7

Merged
guerman5 merged 3 commits into
mainfrom
use-library-calibration-impls
Sep 1, 2026
Merged

guerman5 merged 3 commits into
mainfrom
use-library-calibration-impls

Conversation

@guerman5

Copy link
Copy Markdown
Contributor

Pairs with capullo-audio#6, which moves the four File*/Android* calibration classes next to the interfaces they implement.

QuantumCast deletes its copies and imports them from tech.capullo.audio.calibration instead. No behaviour change — same classes, just no longer duplicated per app.

This is the half that proves the move: QC compiles clean with its own copies gone.

Note the pin. This branch still points at the current capulloAudio commit, so CI will fail to resolve the moved classes until capullo-audio#6 is merged and jitpack has built it. Merge #6 first, then bump the pin here.

The four File*/Android* classes moved into capullo-audio next to the interfaces
they implement. QuantumCast drops its copies and imports them instead.

No behaviour change - same classes, same package-private-to-nobody API, just no
longer duplicated per app.
@guerman5
guerman5 requested a review from gsalinaslopez August 28, 2026 12:22
Pins capullo-audio 1efb53f, which carries the File*/Android* calibration classes
now that capullo-audio#6 is merged.

Verified against the real pin, not the sibling: capullo-audio moved aside,
--refresh-dependencies, arm64 assembleDebug green with QC's own copies deleted.
@guerman5
guerman5 merged commit bd41e7d into main Sep 1, 2026
3 checks passed
@guerman5
guerman5 deleted the use-library-calibration-impls branch September 1, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants