Pick up the web-player plug fix and the background fix; versionCode 15 - #5
Merged
Merged
Conversation
Bumps capulloAudio to bbf1584, which brings two capullo-audio changes: - The plug follows audibility, not intent (#4). With autostart on, the button used to go green the moment the player was built, so a first-time visitor saw a page that looked like it was playing and heard nothing - browsers hold audio until a user gesture. It now derives from one state function: off, blocked, paused, connecting, live, and only blocked pulses. - The web player no longer dies in the background on Android (#3): the keep-alive silence loop is 30 s so Chromium classifies the element as persistent, plus a wedged-CONNECTING socket is detected and revived. Verified against the pin with the local capullo-audio sibling moved aside, so the substitution could not mask it; the built APK carries both changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
capulloAudiotobbf1584, picking up two capullo-audio changes:off/blocked/paused/connecting/live), and onlyblockedpulses, because onlyblockedis asking for a tap.Verification
Built with the local
capullo-audiosibling moved aside and--refresh-dependencies, sosettings.gradle.ktssubstitution could not mask the pin. Green, and the resulting APK carries both changes (audioBtnStatepresent, silence loop at 30 s).The plug fix itself was device-verified on the rig before merge: with the autoplay policy enforced, no gesture leaves the plug armed and silent, and one tap reaches flowing.
Note #3 addresses a failure that needs Android 16 to reproduce; the rig phones are SDK 30 and 35, so only a regression check was possible here.