Repository navigation
Drop the settings blocks' horizontalPadding argument; re-pin; versionCode 10 - #1
Merged
Merged
Conversation
…Code 10 capullo-audio 42bc010 bakes the 16dp horizontal inset into BalanceControls and WebPlayerToggles, so the argument this screen was passing no longer exists. Nothing moves: 16dp is exactly what both call sites passed. The re-pin also picks up the public-link segment in the listen QR dialog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
capullo-audio42bc010bakes the 16dp horizontal inset intoBalanceControlsandWebPlayerToggles, so the argument this screen passed no longer exists. Nothing moves: 16dp is exactly what both call sites were passing.The parameter only existed because the two settings screens disagreed about who owns the inset — QuantumCast's
LazyColumninsets nothing and each row pads itself, Telecloud's scrollColumninset every child by 20dp. Telecloud's screen was reshaped to match this one, so the disagreement is gone.Verified
Divider-to-divider, both apps on the same phone, before and after:
Measured on the shipped builds rather than reasoned about. Also verified against the published pin with
../capullo-audiomoved aside.The re-pin additionally picks up the public-link segment in the listen QR dialog (#2), which is inert here: the new segment needs a
publicLinkargument this app does not pass, and itsindex.htmlchange only switches towss://on an https origin.