Skip to content

feat: show referral fee discount #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
380712766-dot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: show referral fee discount #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/components/layout/LabelValue.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
export let value;
export let formatValue = false;
export let note = false;
export let valueNote = false;
export let valueNoteTrigger = 'mouseenter focus';
export let isClickable = false;
export let noPadding = false;
export let isSecondaryColor = false;
Expand All @@ -20,6 +22,12 @@
allowHTML: true
};

$: valueTooltipOptions = {
content: valueNote,
allowHTML: true,
trigger: valueNoteTrigger
};

</script>

<style>
Expand Down Expand Up @@ -72,11 +80,11 @@

<div class='flex-row' class:padded={hasPadding} class:semipadded={hasSemiPadding} class:noPadding={noPadding}>
<div class='label' class:fullOpacity={fullOpacityLabel} class:hasNote={note != false} use:tooltip={tooltipOptions}>{label}</div>
<div class='value' on:click|stopPropagation class:clickable={isClickable} class:secondary={isSecondaryColor}>
<div class='value' on:click|stopPropagation class:clickable={isClickable} class:secondary={isSecondaryColor} use:tooltip={valueTooltipOptions}>
{#if formatValue}
{formatForDisplay(value)}
{:else}
{@html value}
{/if}
</div>
</div>
</div>
38 changes: 35 additions & 3 deletions src/components/trade/order/Fee.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import LabelValue from '@components/layout/LabelValue.svelte'

import { BPS_DIVIDER } from '@lib/config'
import { BPS_DIVIDER, BASE_FEES_BPS } from '@lib/config'
import { marketInfos } from '@lib/stores'

import { formatForDisplay } from '@lib/formatters'
Expand Down Expand Up @@ -43,11 +43,43 @@
let feeAmount = 0;
$: feeAmount = getFeeAmount(totalSize, market, $marketInfos);

function getFeeRate() {
return $marketInfos[market]?.fee || 0;
}

function getBaseFeeRate() {
return BASE_FEES_BPS[market] || getFeeRate();
}

function getReferralDiscountRate() {
const discount = getBaseFeeRate() - getFeeRate();
return discount > 0 ? discount : 0;
}

function getFeeDetails() {
const baseFeeRate = getBaseFeeRate();
const feeRate = getFeeRate();
const referralDiscountRate = getReferralDiscountRate();

if (!baseFeeRate) return 'Fee details loading...';

return [
`Base fee: ${formatForDisplay(baseFeeRate / 100)}%`,
`Referral discount: ${formatForDisplay(referralDiscountRate / 100)}%`,
`Current fee: ${formatForDisplay(feeRate / 100)}%`
].join('<br>');
}

let feeDetails;
$: feeDetails = getFeeDetails(market, $marketInfos);

</script>

<LabelValue
label={`Fee (${formatForDisplay(($marketInfos[market]?.fee || 0)/100)}%)`}
label={`Fee (${formatForDisplay(getFeeRate()/100)}%)`}
value={`${feeAmount ? `${formatForDisplay(feeAmount)} ${asset}` : '-'}`}
valueNote={feeDetails}
valueNoteTrigger='click mouseenter focus'
isClickable={true}
isSecondaryColor={isSecondaryColor}
/>
/>